Skip to content

Only update TransactionController state if got updates - #52

Merged
brunobar79 merged 3 commits into
masterfrom
fix-tx-state-update-on-polling
Jan 4, 2019
Merged

brunobar79 merged 3 commits into
masterfrom
fix-tx-state-update-on-polling

Conversation

@brunobar79

Copy link
Copy Markdown
Contributor

Because queryTransactionStatuses is running inside a setInterval we're telling GABA that the state was updated even when there are no changes.

This PR adds a flag to make sure the state gets updated only when at least 1 TX status changed.

@brunobar79
brunobar79 requested a review from bitpshr January 4, 2019 05:55
@codecov-io

codecov-io commented Jan 4, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #52   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines        1011   1014    +3     
  Branches      112    113    +1     
=====================================
+ Hits         1011   1014    +3
Impacted Files Coverage Δ
src/TransactionController.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a7af2...7b27df7. Read the comment docs.

@brunobar79
brunobar79 merged commit 8d49413 into master Jan 4, 2019
@whymarrh
whymarrh deleted the fix-tx-state-update-on-polling branch November 5, 2019 17:43
mcmire pushed a commit to mcmire/core that referenced this pull request Jul 17, 2023
* Handle 'toJSON' in JSON validation and sizing

* Return parsed JSON value from validation function

* Rename return type

* Fix lint errors

* Add helper functions

* Slightly simplify code
mcmire pushed a commit to mcmire/core that referenced this pull request Jul 17, 2023
kanthesha pushed a commit that referenced this pull request Oct 11, 2023
* 100% test coverage everywhere
* add nyc config, check coverage, use in CI
* add next handler test case
* add async handle tests
* add sinon; use stub
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
This change deletes the unused CircleCI config
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
Mrtenz pushed a commit to Mrtenz/core that referenced this pull request Jun 17, 2026
* Do not update an STX which doesn't exist anymore

* Andd new UTs for increased coverage

* Update a comment
Naz-Ovh pushed a commit to 0x-fork/metamask-core that referenced this pull request Nov 7, 2026
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants